Skip to content

APPS-4204: Dx-toolkit sanity checks for nextaur json files - #1570

Merged
gabriela-reznik merged 5 commits into
masterfrom
APPS-4204-sanity_checks_nextaur_jsons
Aug 19, 2026
Merged

gabriela-reznik merged 5 commits into
masterfrom
APPS-4204-sanity_checks_nextaur_jsons

Conversation

@gabriela-reznik

Copy link
Copy Markdown
Collaborator

No description provided.

@gabriela-reznik
gabriela-reznik marked this pull request as ready for review August 5, 2026 09:30
Comment on lines +103 to +104
# Region-set consistency between prod and staging
if prod_regions is not None and staging_regions is not None:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only checks regions parity between staging and production asset files of the same type. Is having a different regions in asset files of different types (nextflow, nextaur, awscli) a valid state?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. As far as I know and can observe from the code all assets should be present in a region for nextflow functionalities

"app_asset_projects_ids_staging.json",
):
filepath = os.path.join(NEXTFLOW_DIR, filename)
validate_asset_file(filepath, PROJECT_ID_RE, "project", errors)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to previous comment - is parity of regions between the records and projects not necessary?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in here we are just checking for assets project IDs but yes, they should have parity in stg and prod

gabriela-reznik and others added 4 commits August 18, 2026 05:20
fixing python hashes

Co-authored-by: Patrik Šimunič <patrik@simunic.cz>
Co-authored-by: Patrik Šimunič <patrik@simunic.cz>

@wormsik wormsik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gabriela-reznik
gabriela-reznik merged commit ed95c74 into master Aug 19, 2026
3 checks passed
@gabriela-reznik
gabriela-reznik deleted the APPS-4204-sanity_checks_nextaur_jsons branch August 19, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants