Repository navigation
APPS-4204: Dx-toolkit sanity checks for nextaur json files - #1570
Merged
Merged
Conversation
simunic-cz
reviewed
Aug 17, 2026
Comment on lines
+103
to
+104
| # Region-set consistency between prod and staging | ||
| if prod_regions is not None and staging_regions is not None: |
Member
There was a problem hiding this comment.
This only checks regions parity between staging and production asset files of the same type. Is having a different regions in asset files of different types (nextflow, nextaur, awscli) a valid state?
Collaborator
Author
There was a problem hiding this comment.
Good catch. As far as I know and can observe from the code all assets should be present in a region for nextflow functionalities
| "app_asset_projects_ids_staging.json", | ||
| ): | ||
| filepath = os.path.join(NEXTFLOW_DIR, filename) | ||
| validate_asset_file(filepath, PROJECT_ID_RE, "project", errors) |
Member
There was a problem hiding this comment.
Related to previous comment - is parity of regions between the records and projects not necessary?
Collaborator
Author
There was a problem hiding this comment.
in here we are just checking for assets project IDs but yes, they should have parity in stg and prod
simunic-cz
reviewed
Aug 17, 2026
fixing python hashes Co-authored-by: Patrik Šimunič <patrik@simunic.cz>
Co-authored-by: Patrik Šimunič <patrik@simunic.cz>
…b.com/dnanexus/dx-toolkit into APPS-4204-sanity_checks_nextaur_jsons
simunic-cz
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.